willtemperley commented on issue #96: URL: https://github.com/apache/arrow-swift/issues/96#issuecomment-5087187522
@maltzsama was that an AI generated comment? > I would rather get that base agreed before building the integration executable on top of it, because otherwise the executable has no corpus to run against. The executable can take arbitrary files as I pointed out in my previous comment: `arrow-json-integration-test --arrow=/tmp/some.arrow_file --json=/tmp/some.json --mode=VALIDATE` So that can be run against any files you have access to locally. The first steps aren't about testing per-se, they're about getting the testing methodology and integration correct. #185 contains a lot of XCTest code that isn't strictly necessary. This becomes a maintenance burden. Small, focused PRs that build incrementally are much more likely to get merged. Adding `arrow-testing` as a submodule is probably a good idea, but that can be done as a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
