Rich-T-kid commented on PR #10441: URL: https://github.com/apache/arrow-rs/pull/10441#issuecomment-5094434887
>take_record_batch 5 primitive cols no nulls 1024 1.00 3.4±0.02µs ? ?/sec 1.00 3.4±0.01µs ? ?/sec take_record_batch 6 string/binary cols no nulls 1024 1.04 28.0±0.03µs ? ?/sec 1.00 26.9±0.04µs ? ?/sec take_record_batch 7 mixed cols null values 1024 1.01 17.7±0.11µs ? ?/sec 1.00 17.6±0.09µs ? ?/sec take_record_batch 7 mixed cols null values null indices 1024 1.00 14.8±0.05µs ? ?/sec 1.00 14.8±0.04µs ? ?/sec yup like @Jefffrey mentioned this actually adds an extra validation step so there isn't much performance gains. maybe what #8879 was referring to was actually the bounds checks in each of the `take_impl` branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
