Rich-T-kid commented on PR #10441: URL: https://github.com/apache/arrow-rs/pull/10441#issuecomment-5099689786
> im not sure we can do this, since callers can call take without an unsafe block and with check bounds off and pass in an invalid index; this would cause UB via safe interfaces i believe? aah, I think ive come full circle to understand what @Dandandan meant in > We can run consider having both bound-checked and non-bound-checked versions of the private kernels, and use them for take_record_batch for doing the take on >1 arrays. I can update the PR to introduce a new unsafe method that uses unsafe array access methods. The main issue with this would be the code bloat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
