fallintoplace opened a new pull request, #1037:
URL: https://github.com/apache/arrow-go/pull/1037

   ## What changed
   
   Check the final `os.WriteFile` result when generating template output and 
return the failure to `main` for reporting.
   
   ## Why
   
   The generator previously exited successfully when the output could not be 
written, for example when the output path was a directory. That could leave 
stale generated files in place while making the generation step appear 
successful.
   
   The new regression test uses a directory as the output target and verifies 
that `process` returns an error containing the failed path.
   
   ## Validation
   
   `go test -vet=off ./arrow/_tools/tmpl`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to