pitrou commented on code in PR #50335:
URL: https://github.com/apache/arrow/pull/50335#discussion_r3666769681
##########
cpp/src/parquet/decoder.cc:
##########
@@ -2232,6 +2281,23 @@ class DeltaByteArrayFLBADecoder : public
DeltaByteArrayDecoderImpl<FLBAType>,
}
return decoded_values_size;
}
+
+ // Same internal decode as above, but copy the bytes contiguously into the
+ // caller's buffer instead of materializing per-value pointers.
Review Comment:
> Let me think what it would take to implement the `DELTA_BYTE_ARRAY`
decoder that avoids all that overhead.
I think the key is to refactor `GetInternal` to be storage-agnostic, but
that's not trivial since it also delegates to `DeltaLengthByteArrayDecoder`.
Perhaps it's better for another PR.
(the good news is that it would probably also benefit
`DeltaByteArrayDecoderImpl::DecodeArrow`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
