pitrou commented on code in PR #50335:
URL: https://github.com/apache/arrow/pull/50335#discussion_r3665542236
##########
cpp/src/parquet/decoder.cc:
##########
@@ -2232,6 +2281,23 @@ class DeltaByteArrayFLBADecoder : public
DeltaByteArrayDecoderImpl<FLBAType>,
}
return decoded_values_size;
}
+
+ // Same internal decode as above, but copy the bytes contiguously into the
+ // caller's buffer instead of materializing per-value pointers.
Review Comment:
The per-value pointers are still materialized in the temporary
`std::vector<ByteArray>` below, do we want to do something about it? Or do we
think it's good enough (DELTA_BYTE_ARRAY might not be used much with FLBA)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
