HuaHuaY commented on code in PR #50694:
URL: https://github.com/apache/arrow/pull/50694#discussion_r3670709130
##########
cpp/src/parquet/thrift_internal.h:
##########
@@ -306,10 +306,10 @@ static inline EncodedStatistics FromThrift(const
format::Statistics& stats,
out.set_min(stats.min);
}
}
- if (stats.__isset.null_count) {
+ if (stats.__isset.null_count && stats.null_count >= 0) {
Review Comment:
FYI:
- A brief discussion about option 1 and 2
https://github.com/apache/arrow-rs/pull/9619#discussion_r3666586303
- For option 4, we may need to fix
`ParquetFileFragment::EvaluateStatisticsAsExpression` at
`cpp/src/arrow/dataset/file_parquet.cc`. It uses `bool may_have_null =
!statistics.HasNullCount() || statistics.null_count() > 0;` which regards
negative count as zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
