pitrou commented on PR #50694: URL: https://github.com/apache/arrow/pull/50694#issuecomment-5115361930
Why do we care about this? The null_count could be incorrect in other ways (for example larger than num_values or inconsistent with the actual def levels). Writing a negative value is quite unlikely compared to the subtler ways of writing an incorrect value. The bottom line is that an incorrect statistic should not lead to a crash or UB, but it could lead to incorrect results when reading. There's nothing that we can reasonably do against that (the whole point of a statistic is to avoid reading all values, but verifying that a statistic is correct would require reading all values, defeating the point of a statistic). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
