raulcd commented on PR #50687:
URL: https://github.com/apache/arrow/pull/50687#issuecomment-5117773902

   > How about we do:
   >```python
   >    def serve(self):
   >        self.server.get().SetPythonServerRef(self)
   >        try:
   >            with nogil:
   >                check_flight_status(self.server.get().ServeWithSignals())
   >        finally:
   >            self.server.get().ReleasePythonServerRef()
   >```
   
   I don't think calling serve is mandatory. We have plenty of tests where we 
call the constructor and dispatch without ever calling `serve` and those still 
call the individual methods (DoGet/etc) which require the reference. The 
reference should exist from the `Init()` call, in the constructor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to