pitrou commented on code in PR #50687:
URL: https://github.com/apache/arrow/pull/50687#discussion_r3668014728
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -86,6 +86,12 @@ PyFlightServer::PyFlightServer(PyObject* server, const
PyFlightServerVtable& vta
server_.reset(server);
}
+void PyFlightServer::ReleasePythonServerRef() {
+ // Resets OwnedRefNoGIL to break the reference cycle between the C++
FlightServerBase
+ // and the Python object.
+ server_.reset();
Review Comment:
> right now, I think so, because it's called always after Shutdown which
ensure the gRPC server is stopped:
Then it seems things are ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
