prmoore77 opened a new pull request, #4634: URL: https://github.com/apache/arrow-adbc/pull/4634
Fixes #4629. ## What Adds a `win32-arm64-msvc` leg to the Node.js driver manager build/release matrix so `@apache-arrow/adbc-driver-manager` works natively on Windows-on-ARM: - `javascript/package.json`: add `aarch64-pc-windows-msvc` to `napi.targets` and the corresponding `optionalDependencies` entry (mirrored in `package-lock.json`, matching the other not-yet-published 0.25.0 platform packages). - `javascript/npm/win32-arm64-msvc/`: platform package dir, same shape as `win32-x64-msvc`. - `.github/workflows/javascript.yml`: build + test legs on GitHub-hosted `windows-11-arm` runners. - `.github/workflows/packaging.yml`: `node-binaries` matrix entry for `windows-11-arm` / `aarch64-pc-windows-msvc`. - `javascript/.cargo/config.toml`: static CRT for the new target, matching x64. ## Toolchain Addressing the toolchain concern raised on the issue: no third-party LLVM/MinGW distribution is involved anywhere in this build. The addon is Rust/napi-rs, built natively on GitHub-hosted `windows-11-arm` runners with the stock MSVC toolchain via `rustup` — the same chain the existing `x86_64-pc-windows-msvc` leg uses. `aarch64-pc-windows-msvc` was promoted to a **Tier 1** Rust target in Rust 1.91 ([rust-lang/rfcs#3817](https://github.com/rust-lang/rfcs/pull/3817), [tracking issue](https://github.com/rust-lang/rust/issues/145671)), and `win32-arm64-msvc` is a standard napi-rs target. (The llvm-mingw usage David saw is in gizmosql's Go/cgo *driver* build, which is unrelated to the driver manager addon — nothing here depends on it.) ## Testing The test leg builds the SQLite driver from conda-forge deps as on the other platforms; conda-forge has a `win-arm64` platform, but if any dependency turns out to be missing there I'm happy to trim this to a build-only leg. We can also exercise the published addon against a native win_arm64 ADBC driver on our windows-11-arm CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
