prmoore77 commented on code in PR #4634:
URL: https://github.com/apache/arrow-adbc/pull/4634#discussion_r3679995116
##########
.github/workflows/javascript.yml:
##########
@@ -169,18 +173,35 @@ jobs:
name: bindings-${{ matrix.settings.target }}
path: javascript
- name: Setup conda (Windows)
- if: runner.os == 'Windows'
+ # Miniforge does not publish a Windows ARM64 installer, so the ARM64
+ # leg gets SQLite from vcpkg below instead.
+ if: runner.os == 'Windows' && runner.arch != 'ARM64'
uses:
conda-incubator/setup-miniconda@8ee1f361103df19b6f8c8655fd3967a8ecb162d5 #
v4.0.1
with:
miniforge-version: latest
- name: Install C++ dependencies (Windows)
- if: runner.os == 'Windows'
+ if: runner.os == 'Windows' && runner.arch != 'ARM64'
run: conda install -c conda-forge --file ci/conda_env_cpp.txt
Review Comment:
Done — the win-arm64 test leg now uses the conda-forge flow via micromamba
instead of vcpkg (562b35c). Two notes on the implementation:
- `mamba-org/setup-micromamba` is not on the ASF actions allowlist
([approved_patterns.yml](https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml)
only has `conda-incubator/setup-miniconda`), so the step downloads the
official `micromamba-win-arm64.exe` from mamba-org/micromamba-releases
directly, pinned to 2.8.1-0 with a sha256 check. If you'd rather get
`setup-micromamba` added to the allowlist and use the action, happy to
switch — this seemed like the lower-friction path for now.
- conda-forge's `win-arm64` platform doesn't have `cmake`, `compilers`,
`libpq`, or `pkg-config` yet, so the leg installs just `libsqlite` (what
the test driver build needs) and uses the runner's preinstalled MSVC and
CMake rather than the full `ci/conda_env_cpp.txt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
