ethantang93 opened a new pull request, #10507: URL: https://github.com/apache/arrow-rs/pull/10507
# Which issue does this PR close? closes #10471 # Rationale for this change The Miri workflow currently covers only a subset of packages. This adds more miri coverage to detect unsafe code, Parquet crate remains excluded because it is tracked separately in #614. # What changes are included in this PR? - Adds Miri testing for arrow, arrow-avro, arrow-cast, arrow-csv, arrow-ipc, arrow-json, arrow-row, arrow-select, and arrow-string. - Updates the gh action workflow path filters in `miri.yaml`, some crates were missing before - adds ignore to tests that takes too long to run - adds ignore to tests that were failing due to inline assembly - Sets `INSTA_WORKSPACE_ROOT` to prevent snapshot tests from invoking unsupported subprocess operations under Miri note: it takes about 50mins to run miri on my M3 laptop. when this pr gets merge i think it's expected to prolong the CI time in the miri workflow, but we can always add more parallel workers # Are these changes tested? i ran the following to test locally. - `rustup run nightly bash .github/workflows/miri.sh` (runs the whole miri suite) - `cargo test` - `cargo clippy --workspace --all-targets --all-features -- -D warnings` - `git diff --check` # Are there any user-facing changes? no, only tests # AI disclosure I used codex to draft this pr after i got the project and miri tests running on my laptop. I have reviewed all the code and have built, tested these changes. I am happy to own follow-ups too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
