Jefffrey commented on code in PR #10507:
URL: https://github.com/apache/arrow-rs/pull/10507#discussion_r3709762835
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -1094,6 +1094,7 @@ mod tests {
}
#[test]
+ #[cfg_attr(miri, ignore)]
Review Comment:
could we add comments for each ignore to indicate if its due to slowness,
unsupported by miri, etc.?
##########
arrow-ipc/src/reader.rs:
##########
@@ -3797,7 +3798,7 @@ mod tests {
let width = data_type.primitive_width().unwrap();
let data = ArrayData::builder(data_type)
.len(len)
- .add_buffer(Buffer::from(vec![0_u8; len * width]))
+ .add_buffer(Buffer::from(MutableBuffer::from_len_zeroed(len *
width)))
Review Comment:
is there some miri issue here being fixed?
##########
arrow-ipc/src/writer.rs:
##########
@@ -4582,7 +4601,7 @@ mod tests {
let out: Vec<u8> = writer.into_inner().unwrap();
- let buffer = Buffer::from_vec(out);
+ let buffer = Buffer::from_slice_ref(out);
Review Comment:
same with these, is there some issue with miri?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
