Jefffrey commented on code in PR #10492:
URL: https://github.com/apache/arrow-rs/pull/10492#discussion_r3709686951
##########
arrow/Cargo.toml:
##########
@@ -74,6 +74,9 @@ prettyprint = ["arrow-cast/prettyprint"]
# target without assuming an environment containing JavaScript.
test_utils = ["dep:rand", "dep:half"]
pyarrow = ["ffi", "dep:arrow-pyarrow"]
+# Record the Python type of each pyarrow conversion in PyO3's introspection
data, so that stub
+# generators emit e.g. `pyarrow.Array` rather than `_typeshed.Incomplete`.
Implies `pyarrow`.
+experimental-inspect = ["pyarrow", "arrow-pyarrow/experimental-inspect"]
Review Comment:
should this be `pyarrow-experimental-inspect` since we're in the arrow crate?
##########
arrow-pyarrow/src/lib.rs:
##########
@@ -645,3 +752,73 @@ fn wrapping_type_error(py: Python<'_>, error: PyErr,
message: String) -> PyErr {
e.set_cause(py, Some(error));
e
}
+
+#[cfg(all(test, feature = "experimental-inspect"))]
+mod introspection_tests {
Review Comment:
do these tests get run in our CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
