jonasdedden commented on code in PR #10492:
URL: https://github.com/apache/arrow-rs/pull/10492#discussion_r3715482536
##########
arrow-pyarrow/src/lib.rs:
##########
@@ -645,3 +752,73 @@ fn wrapping_type_error(py: Python<'_>, error: PyErr,
message: String) -> PyErr {
e.set_cause(py, Some(error));
e
}
+
+#[cfg(all(test, feature = "experimental-inspect"))]
+mod introspection_tests {
Review Comment:
They are now (sorry), by putting an additional `cargo test` call
[here](https://github.com/apache/arrow-rs/pull/10492/changes#diff-82454b2fc887e9985b9348b8f3bca03d2f839645a4c3ba1f3f850014d7da5c8bR233)
in `.github/workflows/integration.yml`. Because the test is feature gated, I
chose that place; if you have a better suggestion, please let me know.
##########
arrow/Cargo.toml:
##########
@@ -74,6 +74,9 @@ prettyprint = ["arrow-cast/prettyprint"]
# target without assuming an environment containing JavaScript.
test_utils = ["dep:rand", "dep:half"]
pyarrow = ["ffi", "dep:arrow-pyarrow"]
+# Record the Python type of each pyarrow conversion in PyO3's introspection
data, so that stub
+# generators emit e.g. `pyarrow.Array` rather than `_typeshed.Incomplete`.
Implies `pyarrow`.
+experimental-inspect = ["pyarrow", "arrow-pyarrow/experimental-inspect"]
Review Comment:
Changed it to that name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
