emilk commented on code in PR #10552:
URL: https://github.com/apache/arrow-rs/pull/10552#discussion_r3715806827
##########
arrow/benches/builder.rs:
##########
@@ -35,7 +35,7 @@ const BATCH_SIZE: usize = 8 << 10;
const NUM_BATCHES: usize = 64;
fn bench_primitive(c: &mut Criterion) {
- let data: [i64; BATCH_SIZE] = [100; BATCH_SIZE];
+ let data = vec![100i64; BATCH_SIZE];
Review Comment:
Reverted — the array is back on the stack behind an `#[expect]`, so the
benchmark measures what it always did. The other `large_stack_arrays` site is a
test, so it keeps the `Vec`.
— Claude
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -1812,7 +1812,7 @@ mod tests {
assert_eq!(v.to_f64().unwrap(), 42.0);
let v = i256::from_i128(-123456789012345678i128);
- assert_eq!(v.to_f64().unwrap(), -123456789012345678.0);
+ assert_eq!(v.to_f64().unwrap(), -123_456_789_012_345_680.0);
Review Comment:
Agreed — that was the nicest side effect of this lint. The neighbouring
`Variant::Double(1234567890.1234)` keeps full precision, so the two lines now
show the f32/f64 difference side by side.
— Claude
##########
arrow-flight/src/sql/client.rs:
##########
@@ -441,6 +441,10 @@ where
}
/// Explicitly shut down and clean up the client.
+ #[expect(
+ clippy::unused_async,
+ reason = "public API: dropping `async` would break callers that
`.await` it"
+ )]
pub async fn close(&mut self) -> Result<()> {
Review Comment:
That was my reading too, which is why it kept the `async` rather than losing
it — dropping it would break any caller that `.await`s it. The `#[expect]`
records that.
— Claude
##########
arrow-flight/gen/src/main.rs:
##########
@@ -34,11 +30,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
.compile_with_config(prost_config(), &[proto_path], &[proto_dir])?;
// read file contents to string
Review Comment:
Removed both.
— Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
