emilk commented on code in PR #10552:
URL: https://github.com/apache/arrow-rs/pull/10552#discussion_r3719950255
##########
parquet/src/file/metadata/thrift/mod.rs:
##########
@@ -427,17 +427,15 @@ fn read_column_metadata<'a>(
// mask for seen required fields in ColumnMetaData
let mut seen_mask = 0u16;
- let mut skip_pes = false;
- let mut pes_mask = true;
- let mut skip_col_stats = false;
- let mut skip_size_stats = false;
-
- if let Some(opts) = options {
- skip_pes = opts.skip_encoding_stats(col_index);
- pes_mask = opts.encoding_stats_as_mask();
- skip_col_stats = opts.skip_column_stats(col_index);
- skip_size_stats = opts.skip_size_stats(col_index);
- }
+ let (skip_pes, pes_mask, skip_col_stats, skip_size_stats) = match options {
+ Some(opts) => (
+ opts.skip_encoding_stats(col_index),
+ opts.encoding_stats_as_mask(),
+ opts.skip_column_stats(col_index),
+ opts.skip_size_stats(col_index),
Review Comment:
yeah, I agree - but I'm also not sure if it bad enough to warrant an
`#[expect` exception 😆 Maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
