zeroshade commented on code in PR #1047:
URL: https://github.com/apache/arrow-go/pull/1047#discussion_r3722277048
##########
arrow/ipc/writer.go:
##########
@@ -136,6 +148,11 @@ func NewWriter(w io.Writer, opts ...Option) *Writer {
}
func (w *Writer) Close() error {
+ if w.err != nil {
+ w.releaseDictionaries()
+ w.pw = nil
+ return w.err
Review Comment:
in this scenario, aren't we leaking the payload writer by not calling Close
on it if we have already started? we'd want to use `errors.Join(w.err,
w.pw.Close())` as the error we will return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
