fallintoplace commented on code in PR #1047:
URL: https://github.com/apache/arrow-go/pull/1047#discussion_r3722341296
##########
arrow/ipc/writer.go:
##########
@@ -136,6 +148,16 @@ func NewWriter(w io.Writer, opts ...Option) *Writer {
}
func (w *Writer) Close() error {
+ if w.err != nil {
+ if w.started && w.pw != nil {
+ if err := w.pw.Close(); err != nil {
+ w.err = errors.Join(w.err, err)
+ }
Review Comment:
Yep, you are right. Simplified it to `w.err = errors.Join(w.err,
w.pw.Close())` and pushed it as 19fa153a. `go test ./arrow/ipc -count=1`
passes. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
