CurtHagenlocher commented on code in PR #400:
URL: https://github.com/apache/arrow-dotnet/pull/400#discussion_r3728436503
##########
src/Apache.Arrow/Arrays/StringViewArray.cs:
##########
@@ -22,33 +25,56 @@
namespace Apache.Arrow
{
- public class StringViewArray : BinaryViewArray, IReadOnlyList<string>
+ public class StringViewArray(ArrayData data) :
BinaryViewArray(ArrowTypeId.StringView, data), IReadOnlyList<string?>
{
- public static readonly Encoding DefaultEncoding = Encoding.UTF8;
+ public static Encoding DefaultEncoding { get; } = new
UTF8Encoding(false);
Review Comment:
To the best of my ability to tell, the BOM is only used in certain specific
contexts such as `StreamWriter`. It is not referenced from `GetByteCount` or
`GetBytes` and so should have no impact on the scenarios we care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
