adamreeve commented on code in PR #400:
URL: https://github.com/apache/arrow-dotnet/pull/400#discussion_r3732035066
##########
src/Apache.Arrow/Arrays/StringViewArray.cs:
##########
@@ -22,33 +25,56 @@
namespace Apache.Arrow
{
- public class StringViewArray : BinaryViewArray, IReadOnlyList<string>
+ public class StringViewArray(ArrayData data) :
BinaryViewArray(ArrowTypeId.StringView, data), IReadOnlyList<string?>
{
- public static readonly Encoding DefaultEncoding = Encoding.UTF8;
+ public static Encoding DefaultEncoding { get; } = new
UTF8Encoding(false);
Review Comment:
OK, I'm confused about how this could have caused problems with DataFusion
then. We only call `GetBytes` and `GetString` on this encoding. I guess that
means this change is harmless, but I'd like to understand what motivated it
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
