alinaliBQ commented on code in PR #50021:
URL: https://github.com/apache/arrow/pull/50021#discussion_r3730413524
##########
cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc:
##########
@@ -758,32 +753,35 @@ TYPED_TEST(ConnectionInfoTest, TestSQLGetInfoDropDomain) {
EXPECT_EQ(static_cast<SQLUINTEGER>(0), value);
}
-TYPED_TEST(ConnectionInfoHandleTest, TestSQLGetInfoDropSchema) {
- // GH-49482 TODO: resolve inconsitent return value for SQL_DROP_SCHEMA and
change test
- // type to `ConnectionInfoTest`
- this->ConnectWithString(this->GetConnectionString(), this->conn);
-
+TEST_F(ConnectionInfoMockTest, TestSQLGetInfoDropSchema) {
Review Comment:
Can we change this to a `ConnectionInfoHandleTest` since the mock test and
remote test are testing the same attribute?
```suggestion
TEST_F(ConnectionInfoHandleTest, TestSQLGetInfoDropSchema) {
```
And then we can remove `TEST_F(ConnectionInfoRemoteTest,
TestSQLGetInfoDropSchema) {` as it is duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
