vanshaj2023 commented on PR #50021: URL: https://github.com/apache/arrow/pull/50021#issuecomment-5207846416
@alinaliBQ thanks for the suggestions and for catching my typo-fix. Pushed 870e231a78: - Removed the now-duplicate `ConnectionInfoRemoteTest.TestSQLGetInfoDropSchema` since `TYPED_TEST(ConnectionInfoHandleTest, TestSQLGetInfoDropSchema)` already covers both backends. - Updated the comment to mention both SQLite and Dremio. Left `TestSQLGetInfoDropTable` as separate mock/remote `TEST_F`s since those two backends genuinely disagree on the value (mock expects `SQL_DT_DROP_TABLE`, remote expects `0`), so it can't be consolidated the same way. Also noted #50828 for the missing remote `CreateTable`/`CreateSchema` coverage, thanks for filing that separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
