fallintoplace commented on code in PR #1097:
URL: https://github.com/apache/arrow-go/pull/1097#discussion_r3734323616
##########
arrow/ipc/file_reader.go:
##########
@@ -75,6 +75,9 @@ func validateFileBlock(offset int64, meta int32, body,
fileSize, maxMetadataSize
if body < 0 {
return fmt.Errorf("arrow/ipc: invalid file block body length
%d", body)
}
+ if body%8 != 0 {
+ return fmt.Errorf("arrow/ipc: file block body length %d is not
a multiple of 8", body)
+ }
Review Comment:
Just to confirm, do you want arrow-go to intentionally be more lenient here
than the C++ reader? C++ currently rejects file blocks whose body length isn't
8-byte aligned via `CheckAligned`, and the IPC format also requires 8-byte
alignment.
I'm happy to keep the Go reader lenient if that's the preferred
compatibility policy, just wanted to check that the difference is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
