zeroshade commented on code in PR #1097:
URL: https://github.com/apache/arrow-go/pull/1097#discussion_r3736972275
##########
arrow/ipc/file_reader.go:
##########
@@ -75,6 +75,9 @@ func validateFileBlock(offset int64, meta int32, body,
fileSize, maxMetadataSize
if body < 0 {
return fmt.Errorf("arrow/ipc: invalid file block body length
%d", body)
}
+ if body%8 != 0 {
+ return fmt.Errorf("arrow/ipc: file block body length %d is not
a multiple of 8", body)
+ }
Review Comment:
ah, i thought the C++ reader was more lenient. If the C++ reader is also
strict on this then it's fine and we can leave it strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
