zeroshade commented on PR #732: URL: https://github.com/apache/arrow-go/pull/732#issuecomment-5218826168
> What is your opinion on s.Require.False() vs s.False()? I haven't found a canonical way to handle these (although I understand in how their behavior differs). Generally my way of looking at it is pretty much what you describe, whether I find the subsequent tests still interesting/useful if the condition I'm asserting fails. Essentially if I'm testing a condition that if it fails I know that every subsequent assertion in the test will fail, then I just use `Require` so that it bails out early on the first failure. If I just want to assert something but it's still useful for diagnostic (or other test cases) for the test to continue, then I don't use `Require` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
