ennuite commented on code in PR #732:
URL: https://github.com/apache/arrow-go/pull/732#discussion_r3790099189
##########
arrow/flight/flightsql/server.go:
##########
@@ -155,6 +155,9 @@ type ActionCreatePreparedStatementResult struct {
Handle []byte
DatasetSchema *arrow.Schema
ParameterSchema *arrow.Schema
+ // IsUpdate indicates whether the prepared statement should be executed
+ // as an update (true) or query (false). If nil, the client can choose.
+ IsUpdate *bool
Review Comment:
I'm a bit confused because this comment is mixing 2 distinct structs.
The type alias refers to `flightsql.CreatePreparedStatementResult`. This is
the raw proto version, what goes in the wire, and I think it's there so that
users of the `flightsql` package don't need to import the proto package
directly. In this codebase, this is only used in
`LoadPreparedStatementFromResult()`
But the line about the unkeyed literal is referring to a different struct
`flightsql.ActionCreatePreparedStatementResult`. It is defined in server.go,
and it is a developer-friendly type with the *arrow.Schema objects decoded from
wire format. It is used all over the codebase. It is unrelated to the alias.
Thank you for pointing out the compatibility rules, for reference I found
them at
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
