cakeni opened a new pull request, #10632: URL: https://github.com/apache/arrow-rs/pull/10632
# Which issue does this PR close? - Part of #10245. # Rationale for this change Using `Vec` instead of `BufferBuilder` can benefit from Rust's optimized vector implementation. This updates the value and offset builders in `concat_elements_bytes`. # What changes are included in this PR? - Replace the output value and offset `BufferBuilder` instances with capacity-matched vectors. - Use `extend_from_slice` and `push` while preserving the existing offset calculations. - Convert both vectors directly into the buffers used by `ArrayDataBuilder`. # Are these changes tested? Yes. The following checks pass: - `cargo +stable-x86_64-pc-windows-gnu fmt --all -- --check` - `cargo +stable-x86_64-pc-windows-gnu clippy -p arrow-string --all-targets --all-features --no-deps -- -D warnings` - `cargo +stable-x86_64-pc-windows-gnu test -p arrow-string --all-features` (182 unit tests and 10 doctests passed) # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
