jorisvandenbossche commented on issue #46646: URL: https://github.com/apache/arrow/issues/46646#issuecomment-5253845795
I ran into this again and getting annoyed by it. Updating the pre-commit configuration would be a rather easy change, but since I am not using R, I can't evaluate to what extent jarl is a good-enough (for our purposes) replacement of lintr. Asked an LLM, and it says (specifically for our repo): --- But it's not a full drop-in replacement for what r/.lintr currently configures: - `cyclocomp_linter(26)` — jarl has **no cyclomatic-complexity rule at all**, by design. This check would simply disappear, and since lintr is the only place it runs today (no separate CI step), that's a real loss of coverage, not just a local-dev convenience fix. - `object_length_linter(40)` — no jarl equivalent either. - `line_length_linter(120)` — not in jarl (it deliberately punts all formatting concerns to Air) — but this one's already redundant, since r/air.toml already sets line-width = 120 and Air already runs as a pre-commit hook. - `object_name_linter`, `return_linter`, `indentation_linter`, `object_usage_linter` are already disabled (NULL) in r/.lintr, so nothing lost there. - For the remaining active lintr defaults, jarl's 78 rules overlap substantially (`assignment`, `true_false_symbol`, `seq`, `equals_na`, `browser`, etc.) but it's not a guaranteed 1:1 mapping — would need a closer audit. - Docs mentioning `lintr/cyclocomp` (`r/vignettes/developers/workflow.Rmd, docs/source/developers/guide/step_by_step/styling.rst`) would need updating. So: eliminating the hard R dependency is easy and safe. Fully "replacing lintr" cleanly drops complexity/name-length checks with no substitute — that's the real trade-off, not the YAML change itself. --- Do the R devs think that would be fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
