jorisvandenbossche commented on issue #46646: URL: https://github.com/apache/arrow/issues/46646#issuecomment-5266946846
This is definitely a limitation of pre-commit. See also https://github.com/apache/arrow/issues/47937 where this was discussed in context of a hook that requires ruby locally, and I think the conclusion of @thisisnic is that it is not easy to avoid installing all hooks regardless of which files are touched. And indeed for a mono-repo with many different languages, we are running into that limitation .. But switching to something else is even a bigger change (probably), and so _as long as_ we are using pre-commit, I feel that "the hook should install out of the box on most machines" as a rule would be useful to keep this contributor-friendly. Because otherwise, I would actually propose to simply _drop_ those hooks from pre-commit. We don't need pre-commit for CI, where we can easily run the specific linter directly (as we did in the past, although maybe through archery), I think the most value of pre-commit is for the local contributor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
