Copilot commented on code in PR #50851:
URL: https://github.com/apache/arrow/pull/50851#discussion_r3758711664
##########
.pre-commit-config.yaml:
##########
@@ -188,19 +188,12 @@ repos:
?^python/pyarrow/util\.py$|
?^python/pyarrow/vendored/|
)
- - repo: local
+ - repo: https://github.com/etiennebacher/jarl-pre-commit
+ rev: "0.5.0"
hooks:
- - id: lintr
+ - id: jarl-check
alias: r
name: R Lint
- language: r
- additional_dependencies:
- - cyclocomp
- - lintr
- - testthat
- entry: |
- Rscript -e "Sys.setenv(NOT_CRAN = 'TRUE');
lintr::expect_lint_free('r')"
- pass_filenames: false
files: >-
^r/.*\.(R|Rmd)$
Review Comment:
`jarl.toml` is added under `r/`, but the pre-commit hook runs from the repo
root. Per Jarl’s config discovery, it only searches `jarl.toml` in the current
working directory and parent directories, so `r/jarl.toml` won’t be picked up;
the excludes there won’t apply and generated files may get linted unexpectedly.
Consider either moving `jarl.toml` to the repo root, or changing the hook to
execute with `cwd=r/` (bearing in mind Windows support / filename path
rewriting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
