bit2swaz commented on PR #10647: URL: https://github.com/apache/arrow-rs/pull/10647#issuecomment-5257568507
also, while migrating the readers i hit one related panic i left out of scope here: `FileReaderBuilder` still does `footer.schema().unwrap()` at [reader.rs#L1252](https://github.com/apache/arrow-rs/blob/fc16607ccfdb298557ed6630742941761ac18ce3/arrow-ipc/src/reader.rs#L1252), so a malformed IPC file whose footer has no schema table still aborts it predates this PR and sits on a different path from the `fb_to_schema` fix, so i kept it out to keep the diff focused @alamb pinging you because i think you're the best person for this: do you think i should fold the fix into this PR, or file a separate issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
