Jefffrey commented on PR #10647: URL: https://github.com/apache/arrow-rs/pull/10647#issuecomment-5274666155
> @Jefffrey took your other two notes, pushed > > > we can deprecate this function > > the `From<crate::Field> for Field` impl cant take `#[deprecated]` cleanly since its a trait impl on a public conversion path. the real target is `fb_to_schema`, the panicking fn that `try_fb_to_schema` now replaces > > do you want me to deprecate `fb_to_schema`? if so ill fold it into this PR since is just the attribute + fixing the in-tree callers yes my comment was on `fb_to_schema` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
