Rich-T-kid commented on code in PR #10641:
URL: https://github.com/apache/arrow-rs/pull/10641#discussion_r3761524446
##########
arrow-select/src/zip.rs:
##########
@@ -473,10 +473,11 @@ impl<T: ByteArrayType> BytesScalarImpl<T> {
/// return an output array that has
/// `value` in all locations where predicate is true
/// `null` otherwise
+ #[allow(clippy::type_complexity)]
fn get_scalar_and_null_buffer_for_single_non_nullable(
predicate: BooleanBuffer,
value: &[u8],
- ) -> (Buffer, OffsetBuffer<T::Offset>, Option<NullBuffer>) {
+ ) -> Result<(Buffer, OffsetBuffer<T::Offset>, Option<NullBuffer>),
ArrowError> {
Review Comment:
return type uses T::Offset which is a generic associated type, making a
standalone type alias impossible;
adding a clippy suppress here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
