Jefffrey commented on code in PR #10641:
URL: https://github.com/apache/arrow-rs/pull/10641#discussion_r3771656848
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -457,20 +457,28 @@ impl FixedSizeBinaryArray {
// sufficient capacity in the underlying mutable buffer for
// the data.
if let Some(capacity) = iter_size_hint.checked_mul(len) {
- buffer.reserve(capacity);
+ buffer
+ .try_reserve(capacity)
+ .map_err(|e|
ArrowError::MemoryError(e.to_string()))?;
Review Comment:
oh thats a bugger 🤔
maybe better off without this then, to avoid this dependency just for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
