etseidl commented on code in PR #10653: URL: https://github.com/apache/arrow-rs/pull/10653#discussion_r3761972482
########## parquet/src/file/metadata/mod.rs: ########## @@ -141,29 +141,31 @@ pub(crate) use writer::ThriftMetadataWriter; /// documentation]. Each [`ColumnIndex`] holds statistics about all the pages in a /// particular column chunk. /// -/// `column_index[row_group_number][column_number]` holds the +/// `column_index[row_group_number][column_number]` holds the optional /// [`ColumnIndex`] corresponding to column `column_number` of row group -/// `row_group_number`. +/// `row_group_number`. This will be `None` if no index is present for the given +/// column chunk. /// /// For example `column_index[2][3]` holds the [`ColumnIndex`] for the fourth /// column in the third row group of the parquet file. /// /// [PageIndex documentation]: https://github.com/apache/parquet-format/blob/master/PageIndex.md /// [`ColumnIndex`]: crate::file::page_index::column_index::ColumnIndexMetaData -pub type ParquetColumnIndex = Vec<Vec<ColumnIndexMetaData>>; +pub type ParquetColumnIndex = Vec<Vec<Option<ColumnIndexMetaData>>>; Review Comment: The changes here are the big change...the rest is dealing with the consequences -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
