etseidl commented on code in PR #10653:
URL: https://github.com/apache/arrow-rs/pull/10653#discussion_r3761977630
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -678,14 +678,14 @@ macro_rules! get_data_page_statistics {
$values_iter: ident,
$page_statistics: ident
) => {{
- let chunks: Vec<(usize, &ColumnIndexMetaData)> = $iterator.collect();
+ let chunks: Vec<(usize, Option<&ColumnIndexMetaData>)> =
$iterator.collect();
let capacity: usize = chunks.iter().map(|c| c.0).sum();
match $data_type {
DataType::Boolean => {
let mut b = BooleanBuilder::with_capacity(capacity);
for (len, index) in chunks {
match index {
- ColumnIndexMetaData::BOOLEAN(index) => {
+ Some(ColumnIndexMetaData::BOOLEAN(index)) => {
Review Comment:
There is a great deal of repetition in this module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
