otegami opened a new pull request, #50854:
URL: https://github.com/apache/arrow/pull/50854

   ### Rationale for this change
   
   Building a fixed size binary Arrow array from Ruby objects is convenient.
   
   ### What changes are included in this PR?
   
   Accept:
   
   * `ArrowFormat::FixedSizeBinaryArray.new(byte_width, values)`
   * `ArrowFormat::FixedSizeBinaryArray.new(type, values)`
   
   `ArrowFormat::FixedSizeBinaryType.try_convert` is added for the byte width 
shorthand, in the same way as `ArrowFormat::Time32Array.new(unit, values)`. The 
existing 4 arguments form is kept.
   
   Decimal arrays are out of scope. `ArrowFormat::DecimalArray#to_a` returns 
`BigDecimal`, so building one from Ruby objects needs a conversion between 
`BigDecimal` and two's complement. I would like to open a separate issue for it.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes.
   
   * GitHub Issue: #50832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to