otegami commented on code in PR #50854: URL: https://github.com/apache/arrow/pull/50854#discussion_r3774466680
########## ruby/red-arrow-format/lib/arrow-format/array.rb: ########## @@ -852,7 +852,21 @@ def type end class FixedSizeBinaryArray < Array - def initialize(type, size, validity_buffer, values_buffer) + include BufferAlignable + + def initialize(type, *args) + unless type.is_a?(Type) Review Comment: `ArrowFormat::Array#==` compares only the type, the size, and the validity structure. `ArrowFormat::BinaryArray` and `ArrowFormat::UTF8Array` behave the same, so this isn't specific to fixed-size binary. Comparing values needs `#each`, which is missing. I'll handle it in the same follow-up issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
