Naurder commented on PR #50153: URL: https://github.com/apache/arrow/pull/50153#issuecomment-5269885574
@pitrou @zanmato1984 A summary: - Addressed the original review feedback by moving the decimal CTypeTraits specializations after the corresponding TypeTraits. - Added the missing Decimal32 and Decimal64 mappings alongside Decimal128 and Decimal256. - Added compile-time coverage for all four decimal mappings. - Rebasing the PR onto the current main removed the previous stale CI failures. - The fresh CI run is now down to 1 failing check, with 42 successful checks. I checked the remaining ARM64 macOS GLib & Ruby failure. It happens while compiling the GCS filesystem because a deprecated absl::visit call in the google-cloud-cpp / Abseil dependency chain is promoted to an error by -Werror. It does not appear related to the decimal CTypeTraits changes, and the same macOS job has also been failing on recent main runs. From my side, the requested changes are complete and I believe the PR is ready for final review. Thank you both for the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
