zanmato1984 commented on code in PR #50153:
URL: https://github.com/apache/arrow/pull/50153#discussion_r3770035043
##########
cpp/src/arrow/type_traits.h:
##########
@@ -357,6 +357,26 @@ struct TypeTraits<Decimal256Type> {
constexpr static bool is_parameter_free = false;
};
+template <>
+struct CTypeTraits<Decimal32> : TypeTraits<Decimal32Type> {
+ using ArrowType = Decimal32Type;
+};
+
+template <>
+struct CTypeTraits<Decimal64> : TypeTraits<Decimal64Type> {
+ using ArrowType = Decimal64Type;
+};
+
+template <>
+struct CTypeTraits<Decimal128> : TypeTraits<Decimal128Type> {
+ using ArrowType = Decimal128Type;
+};
+
+template <>
+struct CTypeTraits<Decimal256> : TypeTraits<Decimal256Type> {
+ using ArrowType = Decimal256Type;
+};
Review Comment:
For consistency with the other `CTypeTraits` specializations in this file,
could we keep the public inheritance explicit here?
```suggestion
struct CTypeTraits<Decimal32> : public TypeTraits<Decimal32Type> {
using ArrowType = Decimal32Type;
};
template <>
struct CTypeTraits<Decimal64> : public TypeTraits<Decimal64Type> {
using ArrowType = Decimal64Type;
};
template <>
struct CTypeTraits<Decimal128> : public TypeTraits<Decimal128Type> {
using ArrowType = Decimal128Type;
};
template <>
struct CTypeTraits<Decimal256> : public TypeTraits<Decimal256Type> {
using ArrowType = Decimal256Type;
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
