emilk commented on code in PR #10673:
URL: https://github.com/apache/arrow-rs/pull/10673#discussion_r3774941146
##########
arrow-ord/src/comparison.rs:
##########
@@ -100,7 +100,7 @@ where
for j in 0..list.len() {
if list.is_valid(j) && (left.value(i) == list.value(j)) {
bit_util::set_bit(bool_slice, i);
- continue;
+ break;
Review Comment:
here too
##########
arrow-ord/src/comparison.rs:
##########
@@ -100,7 +100,7 @@ where
for j in 0..list.len() {
if list.is_valid(j) && (left.value(i) == list.value(j)) {
bit_util::set_bit(bool_slice, i);
- continue;
+ break;
Review Comment:
Same as above — behaviour-preserving, the inner loop only sets the one bit.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
