emilk commented on code in PR #10673:
URL: https://github.com/apache/arrow-rs/pull/10673#discussion_r3775036625
##########
arrow-data/src/equal/list_view.rs:
##########
@@ -81,26 +73,11 @@ pub(super) fn list_view_equal<T: ArrowNativeType + Integer>(
}
} else {
// Need to integrate validity check in the inner loop.
- // non-null pathway: all sizes must be equal, and all values must be
equal
- let lhs_range_sizes = &lhs_sizes[lhs_start..lhs_start + len];
- let rhs_range_sizes = &rhs_sizes[rhs_start..rhs_start + len];
-
+ // The sizes are not compared here: they can differ where the value is
null.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
