alamb commented on code in PR #10689:
URL: https://github.com/apache/arrow-rs/pull/10689#discussion_r3789219465
##########
arrow/benches/comparison_kernels.rs:
##########
@@ -530,6 +530,23 @@ fn add_benchmark(c: &mut Criterion) {
b.iter(|| eq(&dict_arr_a, &dict_arr_b).unwrap())
});
+ // eq scalar benchmarks across sizes: 16 bytes of view a row, so the
largest is bandwidth-bound
+
+ let mut group = c.benchmark_group("stringview_scalar_eq");
Review Comment:
Can you please add this benchmark as a separate PR so I can use our
automated benchmarking scripts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
