alamb commented on code in PR #10689:
URL: https://github.com/apache/arrow-rs/pull/10689#discussion_r3789222452
##########
arrow-ord/src/cmp.rs:
##########
@@ -370,6 +392,44 @@ impl SideInfo<'_> {
}
}
+/// Longest constant whose length and bytes both fit a view's low 64 bits
+const MAX_LOW_HALF_LEN: u32 = 4;
+
+/// Compares every value of a byte-view array against an inlined constant
+///
+/// `None` for any other shape, which the generic path below then handles.
Review Comment:
"returns None" ?
##########
arrow-ord/src/cmp.rs:
##########
@@ -370,6 +392,44 @@ impl SideInfo<'_> {
}
}
+/// Longest constant whose length and bytes both fit a view's low 64 bits
+const MAX_LOW_HALF_LEN: u32 = 4;
+
+/// Compares every value of a byte-view array against an inlined constant
Review Comment:
Maybe point out this attempts a special case with a shot constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
