Lstarsky0 opened a new issue, #10723: URL: https://github.com/apache/arrow-rs/issues/10723
`arrow-cmp` was added to the workspace in #10325 but never wired into `.github/workflows/arrow.yml`, so it is the one `arrow-*` crate outside that workflow's per-crate coverage. What every other arrow crate in `arrow.yml` gets and `arrow-cmp` does not: - `cargo test -p <crate> --all-features` in the `linux-test` job - the clippy block in the `clippy` job — `--all-targets --all-features -- -D warnings`, plus `-D unused_crate_dependencies` in three feature configurations It is also absent from the workflow's `paths:` filter, so a PR touching only `arrow-cmp/**` does not start `arrow.yml` at all. `miri.yaml` does list `arrow-cmp/**`; `arrow.yml` does not. What `arrow-cmp` does get: the workspace `cargo test` in `rust.yml` (macOS and Windows, default features), `cargo fmt --all -- --check`, the MSRV sweep over every `Cargo.toml`, and miri. None of those run clippy. So a lint regression or an unused dependency in this crate reaches `main` unnoticed. `arrow-ord` and `arrow-select` both depend on `arrow-cmp`, and both are covered themselves, but a change made inside `arrow-cmp` is what escapes. Nothing is failing today — I ran the four missing commands at `bb1e6cd0` and they are all clean, 44 tests pass. To check the gap is real rather than theoretical I planted two defects in `arrow-cmp`: a function with `return v.len();` taking `&Vec<u8>` and no doc comment, and an unused `ahash` dependency. `cargo fmt -p arrow-cmp -- --check` and `cargo test -p arrow-cmp` both still exited 0; the four commands above catch them with 3 clippy errors and `extern crate ahash is unused` in all three configurations. Happy to send the patch — it is three additions to `arrow.yml` mirroring what the neighbouring crates already have. Would also like to know if leaving `arrow-cmp` out was deliberate, in which case this can just be closed. Unrelated but in the same file family: `integration.yml` lists `arrow-sort/**` in its path filter. That entry was added in `db9084e7` (2022-12-21); that commit's own tree has no `arrow-sort` directory, no such crate exists on crates.io, and GitHub code search finds the string exactly once in the repository — the workflow line itself. Can drop it in the same PR or leave it alone, whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
