alamb commented on code in PR #10764:
URL: https://github.com/apache/arrow-rs/pull/10764#discussion_r3825312493
##########
arrow-schema/src/ffi.rs:
##########
@@ -194,12 +194,36 @@ impl FFI_ArrowSchema {
Ok(self)
}
- /// Add metadata to the schema
- pub fn with_metadata<I, S>(mut self, metadata: I) -> Result<Self,
ArrowError>
+ /// Add metadata to the schema.
+ ///
+ /// # Safety
+ ///
+ /// Reinterprets `private_data` as a value this crate produced. `self` must
Review Comment:
Let's lead with
> `self` must be a Schema created in `arrow-rs`
As that is the key point (the reinterprets... part of the comment is an
implementation detail)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
