bit2swaz commented on PR #10764: URL: https://github.com/apache/arrow-rs/pull/10764#issuecomment-5387173040
the release-callback check was option B on #10679 and i did try it. `ptr::fn_addr_eq` [can return false for the same function](https://doc.rust-lang.org/std/ptr/fn.fn_addr_eq.html) so it rejects schemas arrow-rs actually built, it broke 6 ffi tests under miri (which CI runs). thats a spurious `Err` on a real schema, which imo is the wrong way to fail your wrapping case is a second false reject: a schema that wrapped its release via `set_release` still owns our `private_data` but won't match `release_schema`: https://github.com/apache/arrow-rs/blob/06edc8fd341ea5f78950f19ad61f5d269a148257/arrow-schema/src/ffi.rs#L315 thats why @alamb, @Jefffrey and i landed on `unsafe` (full thread on #10679) on the smaller two: title is stale from an earlier null-guard version, ill fix it. and yeah its breaking, goes in the next major -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
