ernestprovo23 commented on PR #49372: URL: https://github.com/apache/arrow/pull/49372#issuecomment-5387625617
thanks @pitrou, all four done. dropped the second declaration, `arrow::fs::IsLikelyUri` now lives only in `filesystem.h`. also killed the `internal::` inline forwarder you flagged... that was only there so i wouldn't have to touch callers, which isn't a good reason. the 7 in-tree call sites (mockfs, localfs, filesystem, s3fs x2, azurefs, gcsfs) call it unqualified now and they each already pull `filesystem.h` in through their own fs header, so no new includes. folded both test pairs, the spaces and non-ascii cases are two parametrized tests now instead of four near-identical ones. rebased on main. heads up the workflow runs are sitting at action_required so nothing's actually built on this sha yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
